Re: [PATCH] workqueue: Guarantee work function memory ordering

[Tejun Heo]

Hello, Peter.

On Sat, Feb 22, 2014 at 10:05:53AM -0500, Peter Hurley wrote:
> Given your concerns about the performance impact, maybe we should
> ask Fengguang to run this change through his automated test suites
> to find out what the perf delta is?

It should be fine.  It's more like I just didn't like the idea of it.
Workqueue execution path isn't really light enough for an addition of
single smp_rmb() per work item execution makes any noticeable
difference.  No harm in measuring perf delta but I'm highly skeptical
that there will be any difference which can be measured.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/