Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

[Ray Strode]

Hi,

On Sat, Feb 22, 2014 at 10:16 AM, Hannes Reinecke <hare@xxxxxxx> wrote:
> And of course, checking for "!tty0" is the proper check for serial console.
> Which, of course, means we have to stay with a broken kernel interface for
> ever and ever.
>
> Innovation, here we come.
So just so we're clear:

1) you have every right to try to make s390 work better
2) You have every right to make mistakes in that venture as well (we
all make mistakes after all)
3) You can even unapologetically break userspace and then be snarky about it
4) And, like the above message, you can also ridicule the code using
the kernel interface you broke

Of those things I'd certainly prefer if you stuck to the first two and
skipped the last two.

For bonus points, you could:

5) Reply to Kay, Greg, and David  when they ask questions about the
patch you wrote
6) Offer a follow up patch that acheives your initial objective
without the ensuing breakage
7) Offer any insight you might have on better ways for plymouth to
achieve what it wants to do going forward that would be less
objectionable

--Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/