Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor feature names

[H. Peter Anvin]

On 02/23/2014 01:32 PM, Josh Triplett wrote:
> 
> Because, in order to un-break the build, v3 wraps an ifdef around that
> dependency, to prevent building cpustr.h.  Otherwise, the rule for
> cpustr.h tries and fails to build mkcpustr.
> 

Why did it fail to build mkcpustr?  It would seem that mkcpustr is or at
least ought to be completely agnostic to any of these options.

The extra build machinery here seems completely pointless.

I agree that the #ifdef isn't a big deal, but all this extra machinery
really indicates something is odd.

Oh, and of course, looking at the v2 patchset, the problem is the ifdef
around the mkcapflags shell script which really shouldn't be necessary.
 We may have to add a rule to force capflags.c to be built even if
capflags.o is not requested, but that is fine.

That will cut down on the Makefile hacks considerably, and will avoid
this problem completely.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/