Re: [alsa-devel] [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

From: Lars-Peter Clausen
Date: Sat Mar 01 2014 - 08:05:27 EST


On 03/01/2014 05:34 AM, Mark Brown wrote:
On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote:
Now that all users have been converted to regmap and the config.reg_bits
and config.val_bits can be setted by each user through regmap core API.
So these two params are redundant here.

Actually, I think the way to fix the issue with CODECs doing I/O in
probe is to provide a way for drivers to specify a regmap when
registering the CODEC (rather than during probe) and then move the
initialisation of the regmap before the probe function is called. That
would make set_cache_io() go away entirely.

Yep, that's actually my preference as well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/