Re: [iio:togreg 3/3] WARNING: Reusing the krealloc arg is almost always a bug

[Lars-Peter Clausen]

On 03/02/2014 03:24 AM, Fengguang Wu wrote:
> Hi Lars-Peter,
>
> FYI, there are new warnings show up in
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> head:   bdc8cda1d010887c06bd8c29564b74cd61ec0a7b
> commit: bdc8cda1d010887c06bd8c29564b74cd61ec0a7b [3/3] iio:adc: Add Xilinx XADC driver
>
> scripts/checkpatch.pl 0001-iio-adc-Add-Xilinx-XADC-driver.patch
> # many are suggestions rather than must-fix
> WARNING: Reusing the krealloc arg is almost always a bug
> #1220: drivers/iio/adc/xilinx-xadc-core.c:1138:
> +	indio_dev->channels = krealloc(channels, sizeof(*channels) *

This is actually a false positive, checkpatch thinks that 
'indio_dev->channels' and 'channels' is the same. Added Joe to Cc.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/