Re: [PATCH v21 12/12] x86: Zero-pad the VVAR page

[Ingo Molnar]

* Stefani Seibold <stefani@xxxxxxxxxxx> wrote:

> By coincidence, the VVAR page is at the end of an ELF segment.  As a
> result, if it ends up being a partial page, the kernel loader will
> leave garbage behind at the end of the vvar page.  Zero-pad it to a
> full page to fix this issue.
> 
> This has probably been broken since the VVAR page was introduced.
> On QEMU, if you dump the run-time contents of the VVAR page, you can
> find entertaining strings from seabios left behind.
> 
> It's remotely possible that this is a security bug -- conceivably
> there's some BIOS out there that leaves something sensitive in the
> few K of memory that is exposed to userspace.
> 
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Signed-off-by: Stefani Seibold <stefani@xxxxxxxxxxx>

That's not a valid signoff sequence - if the patch came from Andy then 
the patch needs to contain a From: Andy line as well. If Andy acked or 
reviewed the patch then please add an Acked-by or Reviewed-by line.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/