Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

[Yogesh Chaudhari]

On 2 March 2014 21:19, Levente Kurusa <levex@xxxxxxxxx> wrote:
> Hi,
>
> 2014-03-02 16:40 GMT+01:00 Joe Perches <joe@xxxxxxxxxxx>:
>> On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote:
>>> IMHO, this message is too big. The one we already have is nice and clean.
>>> I would simply do: s/netdev/[subsystem]/ or something among the lines.
>>
>> maybe:
>>
>> "Prefer [subsystem eg: netdev]_$level2 then dev_$level2 then pr_$level to printk(KERN_$orig ...\n"
>
> Excellent, that looks the best and combines the best of two worlds.
>
>>
>> or reference the stackoverflow link
>>
>
> And what if that disappears? Might as well write this to
> Documentation/CodingStyle
> as I have previously mentioned. Yogesh, you want to do this or should I?

I will send in a new patch with both the script file and the
documentation modifications.

>
> --
> Regards,
> Levente Kurusa


Regards
Yogesh

-- 
DREAM IT, CODE IT
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/