Re: [PATCH V5 1/2] x86: IOSF: add dummy functions for loadable modules

[One Thousand Gnomes]

On Mon, 03 Mar 2014 15:21:40 +0800
"Li, Aubrey" <aubrey.li@xxxxxxxxxxxxxxx> wrote:

> On 2014/3/1 10:40, David E. Box wrote:
> > From: "David E. Box" <david.e.box@xxxxxxxxxxxxxxx>
> > 
> > Some loadable modules only need IOSF access on the platforms where it exists.
> > Provide dummy functions to allow these modules to compile and load on the
> > platforms where it doesn't exist.
> 
> This is not the right way, I think.

Disagree. There are various drivers that can use the IOSF interface but
do not need it, and need to also build and run on platforms without it.

The current code IMHO is correct. We want to make sure it builds without
IOSF, but that any attempt to use IOSF in such a runtime errors - that's
what this code does.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/