Re: [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED

[Prarit Bhargava]

On 03/04/2014 05:37 PM, David Rientjes wrote:
> On Tue, 4 Mar 2014, Prarit Bhargava wrote:
> 
>> linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
>> a definition for VECTOR_UNDEFINED = -1.  There is a missing replacement in
>> the io_apic.c file.  Found during debugging of another issue.
>>
>> Cc: Rui Wang <rui.y.wang@xxxxxxxxx>
>> Cc: Michel Lespinasse <walken@xxxxxxxxxx>
>> Cc: Seiji Aguchi <seiji.aguchi@xxxxxxx>
>> Cc: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
>> Cc: janet.morgan@xxxxxxxxx
>> Cc: tony.luck@xxxxxxxxx
>> Cc: ruiv.wang@xxxxxxxxx
>> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
> 
> Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
> 
> I think it would have been better to define VECTOR_UNDEFINED to be (-1) 
> rather than -1, though, to ensure it can't be used erroneously as an 
> arithmetic operation.

Good point David, I'll push a separate patch for your suggestion.  As always,
thanks for acking :)

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/