Re: [PATCH 2/3] soc: keystone: add QMSS driver

[Santosh Shilimkar]

On Wednesday 05 March 2014 05:55 PM, Kumar Gala wrote:
> 
> On Mar 4, 2014, at 8:47 PM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote:
> 
>> On Wednesday 05 March 2014 01:59 AM, Kumar Gala wrote:
>>>
>>> On Feb 28, 2014, at 5:18 PM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote:
>>>
>>>> From: Sandeep Nair <sandeep_n@xxxxxx>
>>>>
>>>> The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>>>> the main hardware sub system which forms the backbone of the Keystone
>>>> Multi-core Navigator. QMSS consist of queue managers, packed-data structure
>>>> processors(PDSP), linking RAM, descriptor pools and infrastructure
>>>> Packet DMA.
>>>>
>>>> The Queue Manager is a hardware module that is responsible for accelerating
>>>> management of the packet queues. Packets are queued/de-queued by writing or
>>>> reading descriptor address to a particular memory mapped location. The PDSPs
>>>> perform QMSS related functions like accumulation, QoS, or event management.
>>>> Linking RAM registers are used to link the descriptors which are stored in
>>>> descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>>>>
>>>> The QMSS driver manages the PDSP setups, linking RAM regions,
>>>> queue pool management (allocation, push, pop and notify) and descriptor
>>>> pool management. The specifics on the device tree bindings for
>>>> QMSS can be found in:
>>>>       Documentation/devicetree/bindings/soc/keystone-qmss.txt
>>>>
>>>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>>> Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
>>>> Cc: Olof Johansson <olof@xxxxxxxxx>
>>>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
>>>> Cc: Grant Likely <grant.likely@xxxxxxxxxx>
>>>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>>>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>>>> Signed-off-by: Sandeep Nair <sandeep_n@xxxxxx>
>>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>>>> ---
>>>> .../devicetree/bindings/soc/keystone-qmss.txt      |  209 +++
>>>> drivers/Kconfig                                    |    2 +
>>>> drivers/Makefile                                   |    3 +
>>>> drivers/soc/Kconfig                                |    2 +
>>>> drivers/soc/Makefile                               |    5 +
>>>> drivers/soc/keystone/Kconfig                       |   15 +
>>>> drivers/soc/keystone/Makefile                      |    5 +
>>>> drivers/soc/keystone/qmss_acc.c                    |  591 ++++++++
>>>> drivers/soc/keystone/qmss_queue.c                  | 1533 ++++++++++++++++++++
>>>> drivers/soc/keystone/qmss_queue.h                  |  236 +++
>>>> include/linux/soc/keystone_qmss.h                  |  390 +++++
>>>> 11 files changed, 2991 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/soc/keystone-qmss.txt
>>>> create mode 100644 drivers/soc/Makefile
>>>> create mode 100644 drivers/soc/keystone/Kconfig
>>>> create mode 100644 drivers/soc/keystone/Makefile
>>>> create mode 100644 drivers/soc/keystone/qmss_acc.c
>>>> create mode 100644 drivers/soc/keystone/qmss_queue.c
>>>> create mode 100644 drivers/soc/keystone/qmss_queue.h
>>>> create mode 100644 include/linux/soc/keystone_qmss.h
>>>
>>> Do you see qmss being able to provide HW support for a qdisc or doing processor to processor communication over something like rpmsg?
>>>
>>> I ask because I do wondering if we should be looking at a drivers/hwqueue as other vendors have similar hardware.
>>>
>> QMSS just provides the programming interfaces so that certain queues can be configured to achieve QOS tree. The actual qdisc should be
>> part of the network driver as such. The queues are such a generic hardware that it can be used for wide variety of usecases and 
>> supporting that through one driver will be really hard. We did talk of hwqueue last year but looks like the usecase variety is
>> too much because of generic nature of them.
>>
>> QMSS isn't used as such for message passing but queue hardware can be used as done by APM hardware which Arnd pointed me on the other
>> thread. As Arnd recommended, the processor to processor communication related drivers should go under drivers/mailbox. One example,
>> was the APM QMTM patchset [1]
>>
>> From first look the QMSS(APM) and QMTM(APM) looked very similar but they actually differ largely the way it works. Thanks to Arnd
>> for useful discussion here at connect, I better understood how the QMTM works.
>>
>> If you know any other hardware, which needs similar interfaces as QMSS, we can surely think of another subsystem. QMSS is
>> largely network usecase dominated but not limited to only those usecases. It is also used by pure drivers/crypto/ or
>> can also be used for data movement for video etc. 
>>

[..]

>> [1] https://lkml.org/lkml/2014/2/14/703
> 
> The Freescale QorIQ Devices have a Queue Manager (QMan) as part of their Data Path Architecture (DPAA).  I haven’t looked at the QMTM from APM, but not sure if mailbox is the best place for these things.  They seem so much more involved than what I’m guessing most people are thinking with mailbox.
> 
I also felt that even for APM case mailbox may not be the right subsystem but seems like
the whole QMTM is based on message passing and thats why Arnd suggested the drives/mailbox

At least for TI QMSS, we didn't find any suitable existing subsystem so far. Arnd also
agreed that we can't fit the QMSS in mailbox subsystem. If there are more hardware which
would like to have similar subsystem interfaces like QMSS, am more than happy to work with
them on common interfaces. As you know, I tried this last year as well but heard none.
Arnd also suggested that we look at interfaces are geared towards more sophisticated
cases like Open VSwitch.

So my current plan is stick to drivers/soc/ and focus more and getting interfaces and
bindings right. So any help reviewing those would be greatly appreciated.

Regards,
Santosh




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/