Re: [PATCH] tile: avoid overflow in ns2cycles

From: Chris Metcalf
Date: Thu Mar 06 2014 - 11:53:31 EST


On 3/4/2014 3:20 AM, Henrik Austad wrote:
> In commit 4cecf6d401a ("sched, x86: Avoid unnecessary overflow in
> sched_clock") and in recent patch "clocksource: avoid unnecessary
> overflow in cyclecounter_cyc2ns()" https://lkml.org/lkml/2014/3/4/17,
> the mult-shift approach is replaced by 2 steps to avoid storing a large,
> intermediate value that could overflow.
>
> arch/tile/kernel/time.c has a similar pattern in cycles2ns, and this
> copies the same pattern in this function
>
> CC: John Stultz <johnstul@xxxxxxxxxx>
> CC: Mike Galbraith <bitbucket@xxxxxxxxx>
> CC: Salman Qazi <sqazi@xxxxxxxxxx>
> Signed-off-by: Henrik Austad <henrik@xxxxxxxxx>
> ---
> arch/tile/kernel/time.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)

Thanks; taken into the tile tree (with some minor whitespace formatting tweaks).

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/