Re: [PATCH 1/9] wireless/rt2x00: don't use PREPARE_WORK in rt2800usb.c

From: Tejun Heo
Date: Fri Mar 07 2014 - 10:26:55 EST


On Thu, Feb 20, 2014 at 03:44:23PM -0500, Tejun Heo wrote:
> PREPARE_[DELAYED_]WORK() are being phased out. They have few users
> and a nasty surprise in terms of reentrancy guarantee as workqueue
> considers work items to be different if they don't have the same work
> function.
>
> Update rt2800usb.c to use INIT_WORK() instead of PREPARE_WORK(). As
> the work item isn't in active use during rt2800usb_probe_hw(), this
> doesn't cause any behavior difference.
>
> It would probably be best to route this with other related updates
> through the workqueue tree.
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Ivo van Doorn <IvDoorn@xxxxxxxxx>
> Cc: Gertjan van Wingerde <gwingerde@xxxxxxxxx>
> Cc: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx

Applied to wq/for-3.15. Please holler if there's any objection.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/