RE: [PATCH 1/1] Drivers: hv: vmbus: Include the limit on the number of pfns we can handle

[KY Srinivasan]

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx]
> Sent: Friday, March 7, 2014 2:51 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> jasowang@xxxxxxxxxx
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Include the limit on the number
> of pfns we can handle
> 
> On Fri, Mar 07, 2014 at 09:07:42AM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx]
> > > Sent: Friday, March 7, 2014 1:46 PM
> > > To: KY Srinivasan
> > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> > > jasowang@xxxxxxxxxx
> > > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Include the limit on
> > > the number of pfns we can handle
> > >
> > > On Thu, Mar 06, 2014 at 11:15:08PM -0800, K. Y. Srinivasan wrote:
> > > > Increase the maximum number of pfns we can handle is a single
> > > > vmbus
> > > packet.
> > >                                                     ^^ in
> >
> > Thanks Dan. I am traveling in India and it shows. I have already sent a
> corrected patch.
> >
> 
> Yeah.  I saw that.  Thanks.
> 
> > > >
> > >
> > > What are the user visible effects of this patch?
> > The current code will drop these packets that have more PFNs than the
> limit.
> > Upping the limit will mitigate this problem.
> >
> 
> Meanwhile, the revised patch says that it is not a bugfix.  It sort of sounds like
> upping the limit does improve performance for some people?
> 
> I am confused now.

With the current network code this condition cannot occur since we neither support scatter/gather I/O
nor segmentation offload. I have submitted patches that enable these features for our network driver.
Once TSO is turned on, the network stack can send packets that may need more than the current limit of
PFNs in a packet.

Hope this helps,

K. Y
> 
> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/