Re: [PATCH 2/5] ARM: lager: add vin1 node

[Sergei Shtylyov]

On 03/07/2014 07:06 PM, Ben Dooks wrote:

> > > Add device-tree for vin1 (composite video in) on the
> > > lager board.

> > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>

> >     This patch should have been preceded by the VIN driver patch and
> > bindings description, don't you think?

> > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> > > b/arch/arm/boot/dts/r8a7790-lager.dts
> > > index a087421..7528cfc 100644
> > > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > [...]
> > > @@ -239,8 +244,41 @@
> > >       status = "ok";
> > >       pinctrl-0 = <&i2c2_pins>;
> > >       pinctrl-names = "default";
> > > +
> > > +    adv7180: adv7180@0x20 {

> >     ePAPR standard [1] tells us that:

> > "The name of a node should be somewhat generic, reflecting the function
> > of the device and not its precise programming model."

> >     So, I would suggest something like "video-decoder" instead. And
> > remove "0x" from the address part of the node name please.

> Personally I'm not fussed about names in the tree.

   I quoted the standard everybody should follow.

> I will look at changing it to something like vin1_decoder

   Please give it a generic name instead, without indexes and underscores.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/