Re: [PATCH 1/2] ktest: add 2nd parameter of run_command() to set the redirect target file

From: Steven Rostedt
Date: Fri Mar 07 2014 - 19:43:38 EST


On Sat, 08 Mar 2014 09:12:31 +0900
Satoru Takeuchi <satoru.takeuchi@xxxxxxxxx> wrote:

> Hi Steven,
>
> At Sun, 02 Mar 2014 21:20:31 +0900,
> Satoru Takeuchi wrote:
> >
> > From: Satoru Takeuchi <satoru.takeuchi@xxxxxxxxx>
> >
> > If we'd like to set the redirect target file of run_command(),
> > we should define $redirect before calling this function and should undef it
> > after calling this function. Since it's user-unfriendly, add 2nd parameter of
> > run_command() for this purpose.
> >
> > Signed-off-by: Satoru Takeuchi <satoru.takeuchi@xxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> Could you tell whether this patch will be applied? Although you told me that you
> won't apply the following patch, I didn't hear about this patch.

Ah, I was thinking this one was needed for the next patch, so I didn't
apply it.

>
> > [PATCH 2/2] ktest: run make mrproper not only for OUTPUT_DIR but also for BUILD_DIR to avoid build failure
>
> I make this question since I'll send next patch set this weekend and want to
> know whether I can make patch on the top of this patch.

You can add this one again. I haven't really reviewed it, but if other
patches depend on it, include it as well. Include it anyway if you want
me to review it.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/