Re: [PATCH v2 2/2] i2c designware add support of I2C standard mode
From: Wolfram Sang
Date: Sun Mar 09 2014 - 04:08:37 EST
> + /* fast mode by default */
Please add "because of legacy reasons" since the usual default is
100kHz.
> + clk_freq = 400000;
> + /* Only standard mode at 100kHz and fast mode at 400kHz
> + * are supported.
> + */
> + if (clk_freq != 100000 && clk_freq != 400000)
> + return -EINVAL;
You didn't add the error message I requested last time.
Attachment:
signature.asc
Description: Digital signature