Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

From: Ben Hutchings
Date: Sun Mar 09 2014 - 14:53:54 EST


On Thu, 2014-03-06 at 03:13 -0800, K. Y. Srinivasan wrote:
[...]
> @@ -593,8 +658,9 @@ static int netvsc_probe(struct hv_device *dev,
> net->netdev_ops = &device_ops;
>
> /* TODO: Add GSO and Checksum offload */
> - net->hw_features = NETIF_F_RXCSUM | NETIF_F_SG;
> - net->features = NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_SG | NETIF_F_RXCSUM;
> + net->hw_features = NETIF_F_RXCSUM | NETIF_F_SG | NETIF_F_IP_CSUM;
> + net->features = NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_SG | NETIF_F_RXCSUM |
> + NETIF_F_IP_CSUM;

Missing NETIF_F_IPV6_CSUM?

Ben.

> SET_ETHTOOL_OPS(net, &ethtool_ops);
> SET_NETDEV_DEV(net, &dev->device);

--
Ben Hutchings
I say we take off; nuke the site from orbit. It's the only way to be sure.

Attachment: signature.asc
Description: This is a digitally signed message part