Re: [PATCH] net: phy: Add sysfs attribute to prevent PHY suspend

[Sebastian Hesselbarth]

On 03/10/2014 12:12 AM, David Miller wrote:
> From: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> Date: Fri,  7 Mar 2014 12:34:52 +0100
>
> > commit 1211ce53077164e0d34641d0ca5fb4d4a7574498
> >    ("net: phy: resume/suspend PHYs on attach/detach")
> > introduced a feature to suspend PHYs when entering halted state.
> >
> > Unfortunately, not all bootloaders properly power-up PHYs on reset
> > and fail to access ethernet because the PHY is still powered down.
> >
> > Therefore, this adds code and documentation for a sysfs attribute to
> > allow/deny PHYs to be suspended on a per-PHY basis. Disabling that
> > attribute prevents PHYs from being suspended when entering halted state.
> >
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> > Reported-by: Andrew Lunn <andrew@xxxxxxx>
>
> I know you won't like what I have to say, but I want to see a solution
> without this sysfs knob.
>
> First of all, you obviously have a way to end up having the sysfs knob
> get set on the appropriate systems.
>
> Therefore, you obviously have some way to propagate the same piece of
> information into the kernel somehow during boot time.
>
> For example, via a device tree property or similar.

There is no way to determine if a bootloader is broken or not. The
sysfs knob allows to provide a use case based decision. Of course, we
can invent some freaky device tree property but that the DT maintainers
will not like either.

This is not an issue with broken HW but SW. The PHY is fine, you can
suspend and resume it perfectly in Linux. But the bootloader fails to
properly initialize it on a warm boot. You could update the bootloader
and the issue disappears.

> Please pursue an avenue such as that.  This sysfs thing, it's a user
> facing interface we'd have to live with forever.

If you want me to try a devicetree property for the issue, we also
create ABI and we will have to live with it forever.

I am open for suggestions, but I have a bad feeling about a "broken
bootloader" DT property.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/