Re: [Intel-gfx] [PATCH v3 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

[Chris Wilson]

On Mon, Mar 10, 2014 at 10:55:40AM +0100, Daniel Vetter wrote:
> On Mon, Mar 10, 2014 at 10:29 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> >> Realized after sending mail that we just get to know current cursor
> >> width and height. Can we have capability that exposes all supported
> >> cursor sizes?
> >
> > The cap exposes the max cursor size. Knowing our hardware we can infer
> > that pot sizes from 64 to max are supported, but it would be better if
> > we did expose that information through the cap as well.
> 
> I think the right approach here is to expose this through the
> cursor-as-real-plane interface, which kinda has this already. On top
> of that we can then add a few fourcc enumerations of the fixed rgba
> cursor layouts like 64x64, 128x128, ... This helps if the plane is a
> general one with very high limits, but also with special support for
> cursor formats.
> 
> If anyone wants to go crazy we could then also add new fourccs for all
> the other cursor layouts - atm only rgba with fixed dimensions can be
> support with the current cursor ioctl.
> 
> So reviewing the overall situation I actually _don't_ want a new
> cap/ioctl/prop here just for now. As long as we need to go with intel
> specific hacks userspace might as well probe things manually and act
> upon the -EINVAL.

Adding the cap allows existing userspace to dtrt...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/