Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

[Ian Abbott]

On 2014-03-09 02:42, Conrad Meyer wrote:
> Brought to you with the help of sed and manual clean-up after.
>
>    $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \
>      addi-data/hwdrv_apci1500.c
>
> Since all of these printk()s were for invalid API inputs and most of
> them returned -EINVAL, I fixed the rest of them to return -EINVAL as
> well.
>
> Signed-off-by: Conrad Meyer <cse.cem@xxxxxxxxx>

In comedi, we usually use dev->class_dev as the device for these sorts 
of messages.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/