Re: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap

[Matt Porter]

On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote:
> 
> > +			csr_reg: regulator@13 {
> > +				reg = <13>;
> > +				regulator-compatible = "csr";
> > +				regulator-min-microvolt = <860000>;
> > +				regulator-max-microvolt = <1440000>;
> > +			};
> 

> You should not be setting voltage ranges like this in a .dtsi - you've
> no idea if these voltage ranges are in fact valid for any given board so
> they can't be set safely.  In general I would not expect to see any
> configuration at all for regulators in an include file for the chip.

Agreed. I moved all constraints where they belong in the board-specific
dts.

Thanks,
Matt

Attachment: signature.asc
Description: Digital signature