Re: [PATCH] i2c-cadence: Do not let signals interrupt I2C transfers

[SÃren Brinkmann]

Hi Mike,

On Tue, 2014-03-11 at 08:07AM +0100, Mike Looijmans wrote:
> Pressing CTRL-C while communicating with an I2C device leads to erratic
> behaviour. The cause is that the controller will interrupt the I2C transfer
> in progress, and leave the client device in an undefined state. Many
> drivers do not handle error return codes on I2C transfers. The calling driver
> has no way of telling how much of the transfer has actually completed, so
> it cannot reliably determine the device's state.
> 
> The best solution here is to not handle signals in the I2C bus driver at all,
> but always complete a transaction before returning control.
> 
> See for a related patch and discussion on this topic:
> http://lkml.org/lkml/2014/1/9/246
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
Acked-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>

Thanks for the update. I'll take these changes and resubmit the driver
to LKML as well.

	SÃren


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/