Re: [PATCH] x86: Dynamically relocate the compat vdso

[H. Peter Anvin]

On 03/11/2014 02:33 PM, Andy Lutomirski wrote:
> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
> index 1aa9ccd..943f166 100644
> --- a/arch/x86/include/asm/pgtable_types.h
> +++ b/arch/x86/include/asm/pgtable_types.h
> @@ -214,13 +214,8 @@
>  #ifdef CONFIG_X86_64
>  #define __PAGE_KERNEL_IDENT_LARGE_EXEC	__PAGE_KERNEL_LARGE_EXEC
>  #else
> -/*
> - * For PDE_IDENT_ATTR include USER bit. As the PDE and PTE protection
> - * bits are combined, this will alow user to access the high address mapped
> - * VDSO in the presence of CONFIG_COMPAT_VDSO
> - */
>  #define PTE_IDENT_ATTR	 0x003		/* PRESENT+RW */
> -#define PDE_IDENT_ATTR	 0x067		/* PRESENT+RW+USER+DIRTY+ACCESSED */
> +#define PDE_IDENT_ATTR	 0x063		/* PRESENT+RW+USER+DIRTY+ACCESSED */
>  #define PGD_IDENT_ATTR	 0x001		/* PRESENT (no other attributes) */
>  #endif
>  

Please make this hunk a separate patch for bisecting reasons.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/