Re: [PATCH net] r8169: fix the incorrect tx descriptor version

From: Francois Romieu
Date: Tue Mar 11 2014 - 18:28:18 EST


Hayes Wang <hayeswang@xxxxxxxxxxx> :
> The tx descriptor version of RTL8111B belong to RTL_TD_0.
>
> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

Acked-by: Francois Romieu <romieu@xxxxxxxxxxxxx>

All 8168b chipsets should had shared the same Tx descriptor layout.

2b7b431858c284b62c18baaf2cea571be2797d5a ("r8169: TSO fixes.") got it
right but it was broken after a couple of weeks by
d58d46b5d85139d18eb939aa7279c160bab70484 ("r8169: jumbo fixes") in 2011:
[...]
[RTL_GIGA_MAC_VER_17] =
- _R("RTL8168b/8111b", RTL_TD_0, NULL),
+ _R("RTL8168b/8111b", RTL_TD_1, NULL, JUMBO_4K, false),
[RTL_GIGA_MAC_VER_18] =

Oops.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/