Re: [PATCH 1/2] Tracepoint API doc update: data argument

From: Mathieu Desnoyers
Date: Tue Mar 11 2014 - 21:30:18 EST


----- Original Message -----
> From: "Steven Rostedt" <rostedt@xxxxxxxxxxx>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@xxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx, "Ingo Molnar" <mingo@xxxxxxxxxx>, "Frederic Weisbecker" <fweisbec@xxxxxxxxx>,
> "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, March 11, 2014 9:14:02 PM
> Subject: Re: [PATCH 1/2] Tracepoint API doc update: data argument
>
> On Wed, 12 Mar 2014 00:52:33 +0000 (UTC)
> Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote:
>
> > ----- Original Message -----
> > > From: "Steven Rostedt" <rostedt@xxxxxxxxxxx>
> > > To: "Mathieu Desnoyers" <mathieu.desnoyers@xxxxxxxxxxxx>
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx, "Ingo Molnar" <mingo@xxxxxxxxxx>,
> > > "Frederic Weisbecker" <fweisbec@xxxxxxxxx>,
> > > "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Sent: Tuesday, March 11, 2014 7:34:50 PM
> > > Subject: Re: [PATCH 1/2] Tracepoint API doc update: data argument
> > >
> > > On Mon, 10 Mar 2014 21:04:57 -0400
> > > Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote:
> > >
> > > > Describe the @data argument (probe private data).
> > > >
> > > > Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to
> > > > tracepoint callbacks"
> > > > CC: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > > CC: Ingo Molnar <mingo@xxxxxxxxxx>
> > > > CC: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > > > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > >
> > > No signed-off-by.
> >
> > Hi Steven,
> >
> > I'm curious to understand the reason of this "no signed-off-by" on a
> > trivial
> > patch that fixes the missing DocBook comments for one of your previous
> > commits that has been upstream for a few years. What am I missing ?
> > Perhaps you meant this reply for my other documentation update patch (2/2)
> > ?
> >
>
> I mean, my scripts wont accept a patch that the author never added
> their signed-off-by to.
>
> In other words, resubmit, and add your own signed-off-by that happens to
> be missing from this patch.

Oh, sorry, I missed that. Will do.

Thanks,

Mathieu

>
> -- Steve
>

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/