Re: [PATCH v2] ASoC: cs42888: Add codec driver support

[Nicolin Chen]

Hi Brian,

On Wed, Mar 12, 2014 at 02:05:00AM +0000, Austin, Brian wrote:
> 
> 
> >> On Mar 11, 2014, at 13:46, "Mark Brown" <broonie@xxxxxxxxxx> wrote:
> >> 
> >> On Tue, Mar 11, 2014 at 04:55:58PM +0100, Lars-Peter Clausen wrote:
> >> On 03/11/2014 04:41 PM, Brian Austin wrote:
> > 
> >>> So WRT the CS42888, this is one device in a series of 2 devices that are
> >>> register compatible with the only difference being that the CS42488 has 2
> >>> extra ADC's. Same die and same DeviceID.
> > 
> >>> Would it make more sense to submit the driver with the extra ADC's to make
> >>> it feature complete for both devices? Wouldn't be odd to have 2 drivers that
> >>> do the same for 98% of the code.
> > 
> >> This should be in one driver. But support for the second device can
> >> always be added in a follow up patch.
> > 
> > Yes, we can add support later.  It might be helpful to name the driver
> > with some generic name I guess.
> CS42xx8 would work.
> 
> We have a CS42448 and the CS42888. The difference is the 2 extra ADC's on the CS42448. I can add those later.
> 
> I still would like to go over some of the v2 code though before a v3 is sent.

Actually I've already sent v3 right after this v2 due to some doc updating.

Anyway, I'd love to wait for your comments against the patch before I send v3.

Thank you,
Nicolin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/