Re: [PATCH] pinctrl: msm: drop wake_irqs bitmap

[Linus Walleij]

On Wed, Mar 5, 2014 at 8:33 PM, Josh Cartwright <joshc@xxxxxxxxxxxxxx> wrote:

> Currently, the wake_irqs bitmap is used to track whether there are any
> gpio's which are configured as wake irqs, and uses this to determine
> whether or not to call enable_irq_wake()/disable_irq_wake() on the
> summary interrupt.
>
> However, the genirq core already handles this case, by maintaining a
> 'wake_count' per irq_desc, and only calling into the controlling
> irq_chip when wake_count transitions 0 <-> 1.
>
> Drop this bitmap, and unconditionally call irq_set_irq_wake() on the
> summary interrupt.
>
> Signed-off-by: Josh Cartwright <joshc@xxxxxxxxxxxxxx>

Delighted to see you folks working on this driver.
Patch applied with Björn's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/