Re: [RESEND] Fast TSC calibration fails with v3.14-rc1 and later

[Thomas Gleixner]

On Wed, 12 Mar 2014, Thomas Gleixner wrote:

> On Wed, 12 Mar 2014, joeyli wrote:
> > I think maybe still using ACPI_FADT_NO_CMOS_RTC to check does
> > acpi_early_init() need run before timekeeping_init().
> > If there have any future machine that applied ACPI TAD but "Fast TSC
> > calibration" fail, at least the alternate TSC calibration can work
> > around issue.
> 
> Well, it can work around, but it sucks as it's way slower than the
> fast one. And we really don't want to pay that price for some half
> baken ACPI nonsense.
> 
> Why exactly do you need that ACPI stuff before timekeeping_init()?

According to the changelog:

    And, we want accessing ACPI TAD device to set system clock, so move
    acpi_early_init() before timekeeping_init(). This final position is
    also before efi_enter_virtual_mode().

Why do we need to access that TAD thing (whatever newfangled that is)
at this point?

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/