Re: [PATCH 2/2] net: Implement SO_PEERCGROUP

From: Cong Wang
Date: Wed Mar 12 2014 - 16:59:08 EST


On Wed, Mar 12, 2014 at 1:46 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> @@ -1098,6 +1135,16 @@ static int unix_stream_connect(struct socket *sock, struct sockaddr *uaddr,
> if (newsk == NULL)
> goto out;
>
> + err = init_peercgroup(newsk);
> + if (err)
> + goto out;
> +
> + err = alloc_cgroup_path(sk);
> + if (err)
> + goto out;
> +
> + err = -ENOMEM;
> +

Don't we need to free the cgroup_path on error path
in this function?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/