Re: [PATCH v2 2/3] mfd: max8997: handle IRQs using regmap

[Chanwoo Choi]

Hi Robert,

On 03/13/2014 04:46 PM, Robert Baldyga wrote:
> Hi,
> On 03/13/2014 03:03 AM, Chanwoo Choi wrote:
>> Hi Robert,
>>
>> On 03/12/2014 10:37 PM, Robert Baldyga wrote:
>>> This patch modifies mfd driver to use regmap for handling interrupts.
>>> It allows to simplify irq handling process. This modifications needed
>>> to make small changes in function drivers, which use interrupts.
>>>
>>> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
>>> ---
>>>  drivers/extcon/extcon-max8997.c     |   35 ++--
>>>  drivers/mfd/Kconfig                 |    2 +-
>>>  drivers/mfd/Makefile                |    2 +-
>>>  drivers/mfd/max8997-irq.c           |  373 -----------------------------------
>>>  drivers/mfd/max8997.c               |  113 ++++++++++-
>>>  drivers/rtc/rtc-max8997.c           |    2 +-
>>>  include/linux/mfd/max8997-private.h |   65 +++++-
>>>  7 files changed, 183 insertions(+), 409 deletions(-)
>>>  delete mode 100644 drivers/mfd/max8997-irq.c
>>>
>>> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
>>> index f258c08..15fc5c0 100644
>>> --- a/drivers/extcon/extcon-max8997.c
>>> +++ b/drivers/extcon/extcon-max8997.c
>>> @@ -46,15 +46,15 @@ struct max8997_muic_irq {
>>>  };
>>>  
>>>  static struct max8997_muic_irq muic_irqs[] = {
>>> -	{ MAX8997_MUICIRQ_ADCError,	"muic-ADCERROR" },
>>> -	{ MAX8997_MUICIRQ_ADCLow,	"muic-ADCLOW" },
>>> -	{ MAX8997_MUICIRQ_ADC,		"muic-ADC" },
>>> -	{ MAX8997_MUICIRQ_VBVolt,	"muic-VBVOLT" },
>>> -	{ MAX8997_MUICIRQ_DBChg,	"muic-DBCHG" },
>>> -	{ MAX8997_MUICIRQ_DCDTmr,	"muic-DCDTMR" },
>>> -	{ MAX8997_MUICIRQ_ChgDetRun,	"muic-CHGDETRUN" },
>>> -	{ MAX8997_MUICIRQ_ChgTyp,	"muic-CHGTYP" },
>>> -	{ MAX8997_MUICIRQ_OVP,		"muic-OVP" },
>>> +	{ MAX8997_MUICIRQ_ADCERROR,	"MUIC-ADCERROR" },
>>> +	{ MAX8997_MUICIRQ_ADCLOW,	"MUIC-ADCLOW" },
>>> +	{ MAX8997_MUICIRQ_ADC,		"MUIC-ADC" },
>>> +	{ MAX8997_MUICIRQ_VBVOLT,	"MUIC-VBVOLT" },
>>> +	{ MAX8997_MUICIRQ_DBCHG,	"MUIC-DBCHG" },
>>> +	{ MAX8997_MUICIRQ_DCDTMR,	"MUIC-DCDTMR" },
>>> +	{ MAX8997_MUICIRQ_CHGDETRUN,	"MUIC-CHGDETRUN" },
>>> +	{ MAX8997_MUICIRQ_CHGTYP,	"MUIC-CHGTYP" },
>>> +	{ MAX8997_MUICIRQ_OVP,		"MUIC-OVP" },
>>>  };
>>
>>
>> Why did you modify interrput name? Did you have some reason?
>> I think this modification don't need it.
> 
> I did it to have one naming convention in max8997-private.h file. Any
> other interrupt names uses upper case, but MUIC iqr's from some reason
> uses CamelCase. I think it's much better to have consistent style in
> entire file.

If you want to modify interrupt name, I think you better separate patch for
this modification. This patch handle only regmap according to the title of this patch.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/