Re: [PATCH 1/2] ARM: dts: berlin2q: add the Marvell Armada 1500 pro (BG2Q) device tree

[Jisheng Zhang]

Hi,

On Thu, 13 Mar 2014 03:43:03 -0700
Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:

> On 13/03/2014 at 10:05:31 +0000, Sebastian Hesselbarth wrote :
> > On 03/12/2014 11:06 AM, Antoine TÃnart wrote:
> > >+			compatible = "arm,cortex-a9-twd-timer";
> > >+			reg = <0xad0600 0x20>;
> > >+			clocks = <&sysclk>;
> > 
> > Playing with Chromecast, I remember local-timer running at sysclk/3 or

twdclk is running at cpuclk/3. 

On chromecast, freq of cpuclk is the same as sysclk. But parent of twdclk
is cpuclk.

> > something. I know berlin2/berlin2cd is wrong here. Can you check that
> > for berlin2q local-timer also runs at sysclk/n?
> > 
> 
> Actually, what we have is sysclk = cpuclk/3 so I guess it depends on
> what you call sysclk.
> 
> > >+			interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
> > >+			status = "okay";
> > >+		};
> > >+
> > >+		apb@e80000 {
> > >+			compatible = "simple-bus";
> > >+			#address-cells = <1>;
> > >+			#size-cells = <1>;
> > >+
> > >+			ranges = <0 0xe80000 0x10000>;
> > >+			interrupt-parent = <&aic>;
> > >+
> > >+			timer0: timer@2c00 {
> > >+				compatible = "snps,dw-apb-timer";
> > >+				reg = <0x2c00 0x14>;
> > >+				interrupts = <8>;
> > >+				clock-freq = <100000000>;
> > >+				status = "okay";
> > >+			};
> > >+
> > >+			timer1: timer@2c14 {
> > >+				compatible = "snps,dw-apb-timer";
> > >+				reg = <0x2c14 0x14>;
> > >+				clock-freq = <100000000>;
> > >+				status = "disabled";
> > >+			};
> > 
> > berlin2/berlin2cd have a vast amount of 8 apb timers. Any timers missing
> > here or did Marvell remove them?

We still have 8 apb timers

> > 
> > 
> > Also for uart, can you please double-check if there is no uart2?
> > 
> 
> We don't have those informations, maybe Jisheng can help ?

uart2 is removed

Thanks,
Jisheng 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/