Re: [PATCH v2 1/3] ARM: dts: berlin2q: add the Marvell Armada 1500 pro

[Sebastian Hesselbarth]

On 03/14/2014 10:48 AM, Antoine TÃnart wrote:
> On 14/03/2014 10:31, Sebastian Hesselbarth wrote:
> > On 03/13/2014 03:06 PM, Antoine TÃnart wrote:
> > > +    clocks {
> > > +        #address-cells = <0>;
> > > +        #size-cells = <0>;
> > > +
> > > +        smclk: sysmgr-clock {
> > > +            compatible = "fixed-clock";
> > > +            #clock-cells = <0>;
> > > +            clock-frequency = <25000000>;
> > > +        };
> > > +
> > > +        sysclk: system-clock {
> > > +            compatible = "fixed-clock";
> > > +            #clock-cells = <0>;
> > > +            clock-frequency = <400000000>;
> > > +        };
> > > +    };
> > > +
> > > +    soc {
> > [...]
> > > +        local-timer@ad0600 {
> > > +            compatible = "arm,cortex-a9-twd-timer";
> > > +            reg = <0xad0600 0x20>;
> > > +            clocks = <&sysclk>;
> >
> > If I understand Jisheng correctly, this should be cpuclk/3. When
> > removing the clocks {} container above, please also take care of
> > it.
> >
> > You can do
> >
> > cpuclk: cpu-clock {
> >      compatible = "fixed-clock";
> >      #clock-cells = <0>;
> >      clock-frequency = <1200000000>; /* <- put correct freq here */
> > };
> >
> > sysclk: system-clock {
> >      compatible = "fixed-factor-clock";
> >      #clock-cells = <0>;
> >      clocks = <&cpuclk>;
> >      clock-multi = <1>;
> >      clock-div = <3>;
> > };
> >
> > Hopefully, we'll have proper clock drivers soon so we can just replace
> > referenced "fixed-*" clocks.
>
> Sure, this is why I only kept one fixed clock in this patch.
>
> I'll add the cpuclk here then.
>
> > > +            timer0: timer@2c00 {
> > > +                compatible = "snps,dw-apb-timer";
> > > +                reg = <0x2c00 0x14>;
> > > +                interrupts = <8>;
> > > +                clock-freq = <100000000>;
> > > +                status = "okay";
> > > +            };
> > > +
> > > +            timer1: timer@2c14 {
> > > +                compatible = "snps,dw-apb-timer";
> > > +                reg = <0x2c14 0x14>;
> > > +                clock-freq = <100000000>;
> > > +                status = "disabled";
> > > +            };
> >
> > Please also add the remaining 6 apb timers.
>
> I don't have any information about the remaining 6 apb timers. I'll ask
> Jisheng.

He replied to v1 of this patch with

"We still have 8 apb timers"

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/