Re: [PATCH v1 03/11] perf: Allow for multiple ring buffers per event
From: Peter Zijlstra
Date: Fri Mar 14 2014 - 06:39:39 EST
On Mon, Feb 17, 2014 at 06:36:59PM -0800, Andi Kleen wrote:
> > I'm not convinced it needs to be a PERF_RECORD_SAMPLE; but some
> > PERF_RECORD_* type for sure.
>
> Adding a header shouldn't be a problem, it's merely wasting 4K.
>
> > Also it must allow interleaving with other > events.
>
> But can you describe a concrete use case where interleaving is better?
I really don't want the multi-buffer nonsense proposed. An event gets
_1_ buffer, that's it.
That also means that if someone redirect another event into this buffer,
it needs to just work.
And because its a perf buffer, people expect it to look like one. So
we've got 'wrap' it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/