Re: [alsa-devel] [PATCH v2 3/4] ASoC: simple-card: accept many DAI links

From: Jyri Sarha
Date: Fri Mar 14 2014 - 07:16:35 EST


On 03/11/2014 11:36 AM, Jean-Francois Moine wrote:
Some simple audio cards may have many DAI links.
This patch extends the simple-card driver for handling such cards.

Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx>
---
[...]

Why can't you just use two simple-card instances in your setup?

You need to update the DT-binding document too when you are changing the binding. That way it would also be easier to follow what you are trying to accomplish here.

The sysclk and tdm properties appear to only work in the dais of the first dai-link and __asoc_simple_card_dai_init() will not be called for other dais at all. The DT-binding of this implementation would look pretty hairy to me.

Best regards,
Jyri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/