Re: next-20140312 - build error in drivers/acpi/sleep.c

[Valdis . Kletnieks]

On Thu, 13 Mar 2014 22:23:51 +0100, "Rafael J. Wysocki" said:

> On Thursday, March 13, 2014 02:48:31 PM Valdis Kletnieks wrote:
> > Seen in the most recent linux-next with a CONFIG_SUSPEND=n .config:
> >   CC      drivers/acpi/sleep.o
> > drivers/acpi/sleep.c: In function 'acpi_sleep_init':
> > drivers/acpi/sleep.c:808:2: error: implicit declaration of function 'acpi_sleep_state_supported' [-Werror=implicit-function-declaration]
> >   if (acpi_sleep_state_supported(ACPI_STATE_S5)) {
> >   ^
> > cc1: some warnings being treated as errors
> > make[2]: *** [drivers/acpi/sleep.o] Error 1
> > make[1]: *** [drivers/acpi] Error 2
> > make: *** [drivers] Error 2

> > Function is defined inside a #ifdef CONFIG_SUSPEND, but used outside of
> > one in acpi_sleep_init().

> git blame points at commit eaa54ccbc:
>
> commit eaa54ccbcf81de987e6978ad457cc9e425b7a8db
> Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Date:   Tue Mar 11 14:08:58 2014 +0100
>
>     ACPI / sleep: Add extra checks for HW Reduced ACPI mode sleep states

This appears to be fixed in next-20140314, with updated commit:

commit a4e90bed511220ff601d064c9e5d583e91308f65
Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Date:   Thu Mar 13 22:11:39 2014 +0100

    ACPI / sleep: Add extra checks for HW Reduced ACPI mode sleep states


Thanks...

Attachment: pgpCiyeaW0uM_.pgp
Description: PGP signature