Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in s626.c

[Chase Southwood]

>On Saturday, March 15, 2014 12:26 AM, "gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

>>On Fri, Mar 14, 2014 at 06:43:37PM -0700, Chase Southwood wrote:
>>>On Tuesday, March 11, 2014 9:26 AM, Ian Abbott <abbotti@xxxxxxxxx> wrote:
>>>>On 2014-03-09 04:00, Chase Southwood wrote:
>>>> This patch changes a handful of while loops to timeouts to prevent
>>>> infinite looping on hardware failure. A couple such loops are in a
>>>> function (s626_debi_transfer()) which is called from critical sections,
>>>> so comedi_timeout() is unusable for them, and an iterative timeout is
>>>> used instead. For the while loops in a context where comedi_timeout() is
>>>> allowed, a new callback function, s626_send_dac_eoc(), has been defined
>>>> to evaluate the conditions that the while loops are testing.  The new
>>>> callback employs a switch statement based on a simple new enum so that
>>>> it is usable for all of the different conditions tested in while loops
>>>> in s626_send_dac().  The proper comedi_timeout() calls are then used.
>>>>
>>>> Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx>
>>>> ---
>>>> Ian, here is a version of this patchset employing the enum you recommended.
>>>> The second patch has been rebased on top of this one.
>>>>
>>>> 2: Used comedi_timeout() where appropriate, introduce callback function
>>>>
>>>> 3: Updated callback to switch on new enum.>
>>>
>>>Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
>>>
>>>For future reference, for patches affecting a single comedi driver, we 
>>>usually title the patches like this:
>>>
>>>staging: comedi: name_of_driver: summary of patch
>>>
>>
>>
>>Hi Greg!
>>
>>I was just writing to inquire whether you were able to add this patch as well as
>>PATCH 2/2 Propagate timeout errors in s626.c, to your queue in their current state.
>>I had to resend this patch to you about a week ago because the subject line got
>>a little messed up, which might have lead to a bit of confusion regarding the 2
>>patch series, and I wanted to check in to see whether you need me to do anything
>>further.
>
>I've been on vacation this week and will dig through my huge patch queue
>next week.  Then I will need another vacation...
>
>Give me a chance to catch up, I'll let you know if I have problems with
>them.>
>
>thanks,
>
>greg k-h

Greg,

Oh shoot, my apologies.  I don't mean to rush you at all!  I'll chill out a bit...

Thanks,
Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/