[PATCH] s390: correct misuses of module_put in appldata_generic_handler.

[Zhouyi Zhou]

correct misuses of module_put in  appldata_generic_handler

Signed-off-by: Zhouyi Zhou <yizhouzhou@xxxxxxxxx>
---
 arch/s390/appldata/appldata_base.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
index 47c8630..683e0282 100644
--- a/arch/s390/appldata/appldata_base.c
+++ b/arch/s390/appldata/appldata_base.c
@@ -343,7 +343,6 @@ appldata_generic_handler(struct ctl_table *ctl, int write,
 		// protect work queue callback
 		if (!try_module_get(ops->owner)) {
 			mutex_unlock(&appldata_ops_mutex);
-			module_put(ops->owner);
 			return -ENODEV;
 		}
 		ops->callback(ops->data);	// init record
@@ -354,7 +353,6 @@ appldata_generic_handler(struct ctl_table *ctl, int write,
 		if (rc != 0) {
 			pr_err("Starting the data collection for %s "
 			       "failed with rc=%d\n", ops->name, rc);
-			module_put(ops->owner);
 		} else
 			ops->active = 1;
 	} else if ((buf[0] == '0') && (ops->active == 1)) {
@@ -365,7 +363,6 @@ appldata_generic_handler(struct ctl_table *ctl, int write,
 		if (rc != 0)
 			pr_err("Stopping the data collection for %s "
 			       "failed with rc=%d\n", ops->name, rc);
-		module_put(ops->owner);
 	}
 	mutex_unlock(&appldata_ops_mutex);
 out:
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/