Re: [PATCH 01/10] perf, tools: Add jsmn `jasmine' JSON parser

[David Ahern]

On 3/14/14, 8:27 PM, Andi Kleen wrote:
> On Fri, Mar 14, 2014 at 04:41:31PM -0600, David Ahern wrote:
> > On 3/14/14, 3:31 PM, Andi Kleen wrote:
> > > @@ -374,6 +376,8 @@ LIB_OBJS += $(OUTPUT)util/stat.o
> > >   LIB_OBJS += $(OUTPUT)util/record.o
> > >   LIB_OBJS += $(OUTPUT)util/srcline.o
> > >   LIB_OBJS += $(OUTPUT)util/data.o
> > > +LIB_OBJS += $(OUTPUT)util/jsmn.o
> > > +LIB_OBJS += $(OUTPUT)util/json.o
> > >
> > >   LIB_OBJS += $(OUTPUT)ui/setup.o
> > >   LIB_OBJS += $(OUTPUT)ui/helpline.o
> >
> > CONFIG driven? Allow a user to omit this.
>
> Why? It has no external dependencies. AFAIK that's the only reason for configs.

We have also talked about config driven builds to allow pieces to be 
omitted -- e.g., to keep binary size down for embedded systems. This is 
clearly a standalone piece so why not add the config upfront now?

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/