[f2fs-dev] [PATCH] f2fs: fix incorrect parsing with option string

From: Chao Yu
Date: Mon Mar 17 2014 - 05:41:36 EST


Previously 'background_gc={on***,off***}' is being parsed as correct option,
with this patch we cloud fix the trivial bug in mount process.

Signed-off-by: Chao Yu <chao2.yu@xxxxxxxxxxx>
---
fs/f2fs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 057a3ef..6597290 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -258,9 +258,9 @@ static int parse_options(struct super_block *sb, char *options)

if (!name)
return -ENOMEM;
- if (!strncmp(name, "on", 2))
+ if (!strncmp(name, "on", strlen(name)))
set_opt(sbi, BG_GC);
- else if (!strncmp(name, "off", 3))
+ else if (!strncmp(name, "off", strlen(name)))
clear_opt(sbi, BG_GC);
else {
kfree(name);
--
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/