Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

From: Mark Brown
Date: Mon Mar 17 2014 - 11:29:27 EST

On Mon, Mar 17, 2014 at 02:44:00PM +0100, Boris BREZILLON wrote:
> Le 17/03/2014 12:55, Mark Brown a écrit :
> >On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote:

> >If this is a clock for the CODEC it should be documented as part of the
> >binding for the CODEC and connected to the CODEC in the device tree
> >rather than being part of a machine driver binding.

> Tell me if I'm mistaken, but doing this would implies a lot of changes.
> The current wm8904 driver does not handle clk retrieval and configuration,
> and I'm afraid that introducing these concepts would break other drivers
> (those
> connecting to a wm8904 codec).

Currently the only mainline users of the device are the Atmel drivers.

> How about adding CCF support as proposed in this series and think about a
> cleaner
> solution for a future release ?

No, DT is an ABI so you can't do that - once something is in DT we're
stuck supporting it so we can't do quick hacks so easily.

Attachment: signature.asc
Description: Digital signature