RE: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)

[Haiyang Zhang]

> -----Original Message-----
> From: Ben Hutchings [mailto:ben@xxxxxxxxxxxxxxx]
> Sent: Monday, March 17, 2014 4:28 PM
> To: Haiyang Zhang
> Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; KY Srinivasan;
> olaf@xxxxxxxxx; jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive
> Side Scaling (vRSS)
> 
> On Sat, 2014-03-15 at 10:18 -0700, Haiyang Zhang wrote:
> [...]
> >  #define RING_SIZE_MIN 64
> > -static int ring_size = 128;
> > +int ring_size = 128;
> >  module_param(ring_size, int, S_IRUGO);  MODULE_PARM_DESC(ring_size,
> > "Ring buffer size (# of pages)");
> 
> You have to add some driver-specific prefix to the variable name if it is going to
> be extern.  (And use module_param_named to avoid changing the parameter
> name too.)
> 
> [...]
> > +u8 hash_key[HASH_KEYLEN] = {
> > +	0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
> > +	0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
> > +	0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
> > +	0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
> > +	0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa };
> [...]
> 
> Same for this one.
> 
I will do.

Thanks,
- Haiyang