Re: [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree

[Mark Brown]

On Tue, Mar 18, 2014 at 10:49:13AM +0000, Charles Keepax wrote:

> +  - wlf,ldo1 : Initial data for the LDO1 regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt

We don't normally prefix the names of the regulator data with a vendor.

> +	np_init = of_get_child_by_name(arizona->dev->of_node, "wlf,ldo1");

You're missing an of_node_put() for this and if you're going to use
hungarian notation please use a convention other people use.  Calling
things _node seems more common.

Attachment: signature.asc
Description: Digital signature