Re: [PATCH v4 3/6] fat: zero out seek range on _fat_get_block

[OGAWA Hirofumi]

Namjae Jeon <linkinjeon@xxxxxxxxx> writes:

> +static void check_fallocated_region(struct inode *inode, sector_t iblock,
> +		unsigned long *max_blocks, struct buffer_head *bh_result)
> +{
> +	struct super_block *sb = inode->i_sb;
> +	sector_t last_block, disk_block;
> +	const unsigned long blocksize = sb->s_blocksize;
> +	const unsigned char blocksize_bits = sb->s_blocksize_bits;
> +
> +	last_block = (MSDOS_I(inode)->mmu_private + (blocksize - 1))
> +		>> blocksize_bits;
> +	disk_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1))
> +		>> blocksize_bits;
> +	if (iblock >= last_block && iblock <= disk_block) {

Maybe off-by-one error. If iblock == disk_block, phys should not be set
by fat_bmap()?
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/