Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

[Tomasz Figa]

On 18.03.2014 12:09, Cho KyongHo wrote:
> On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote:
> > Hi KyongHo,
> >
> > On 14 March 2014 10:35, Cho KyongHo <pullip.cho@xxxxxxxxxxx> wrote:
> > > This patch uses managed device helper functions in the probe().
> > >
> > > Signed-off-by: Cho KyongHo <pullip.cho@xxxxxxxxxxx>
> > > ---
> > [snip]
> >
> > > +       data->clk = devm_clk_get(dev, "sysmmu");
> > > +       if (IS_ERR(data->clk)) {
> > > +               dev_info(dev, "No gate clock found!\n");
> > > +               data->clk = NULL;
> > > +       }
> >
> > Why aren't you returning from here upon error?
>
> It is for the case of a System MMU which does not need clock gating.

Are there really such cases?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/