Re: [PATCH] SPI: Add driver for Cadence SPI controller

[Mark Brown]

On Tue, Mar 18, 2014 at 02:45:09PM +0000, Harini Katakam wrote:

> OK. I dint consider interrupt sharing. 
> Do you think the following implementation would be better?

> status = IRQ_NONE;
> if (intr_status & CDNS_SPI_IXR_MODF_MASK) {
> 	/* Handle this interrupt here */
> 	status = IRQ_HANDLED;
> } else if (intr_status & CDNS_SPI_IXR_TXOW_MASK) {
> 	/* Handle this interrupt here */
> 	status = IRQ_HANDLED;
> }

> return status;

Yes, that looks good.

Attachment: signature.asc
Description: Digital signature