Re: [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree

[Mark Brown]

On Tue, Mar 18, 2014 at 04:07:01PM +0000, Charles Keepax wrote:
> On Tue, Mar 18, 2014 at 11:15:42AM +0000, Mark Brown wrote:
> > On Tue, Mar 18, 2014 at 10:49:13AM +0000, Charles Keepax wrote:

> > > +	np_init = of_get_child_by_name(arizona->dev->of_node, "wlf,ldo1");

> > You're missing an of_node_put() for this and if you're going to use
> > hungarian notation please use a convention other people use.  Calling
> > things _node seems more common.

> The DCVDD one needs an of_node_put but I am not sure this one
> does. As it will be copied into the regulator device of_node by
> the regulator core so wont of_node_put be called when the device
> is destroyed? Admittedly I haven't checked that but seems
> sensible that the device structure would put its of_node when it
> closes down.

You just took an extra reference by calling of_get_child_by_name(), you
need to free it.

Attachment: signature.asc
Description: Digital signature