Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

[Mark Brown]

On Tue, Mar 18, 2014 at 05:22:31PM +0000, Charles Keepax wrote:

> -	/*
> -	 * LDO1 can only be used to supply DCVDD so if it has no
> -	 * consumers then DCVDD is supplied externally.
> -	 */
> -	if (arizona->pdata.ldo1 &&
> -	    arizona->pdata.ldo1->num_consumer_supplies == 0)
> -		arizona->external_dcvdd = true;
> -

Actually now that I look at this again one issue here - the reason this
is in the core is that if the system is using an external DCVDD it may
not be building the regulator driver at all (it won't do anything at
runtime) so the flag would never get set if it's done by the regulator
driver.

Attachment: signature.asc
Description: Digital signature