Re: [PATCH 1/3 Resend] tracing: Use inline task_nice() to get rid of an open coded implementation of it.

[Dongsheng Yang]

On 03/19/2014 10:15 AM, Steven Rostedt wrote:
> On Wed, 12 Mar 2014 18:26:42 +0800
> Dongsheng Yang <yangds.fnst@xxxxxxxxxxxxxx> wrote:
>
> > Function task_nice() was reimplemented as inline function, we can use it here
> > to replace the open coded implementation.
> >
> > Signed-off-by: Dongsheng Yang <yangds.fnst@xxxxxxxxxxxxxx>
> > cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > ---
> >   kernel/trace/trace.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 815c878..dba0e3d 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1003,7 +1003,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
> >   	else
> >   		max_data->uid = task_uid(tsk);
> >   
> > -	max_data->nice = tsk->static_prio - 20 - MAX_RT_PRIO;
> > +	max_data->nice = task_nice(tsk);
> task_nice() is still an extern function in mainline, and this is the
> tracing side. I rather wait till it becomes inline in Linus's tree
> before I take this.

Sounds reasonable to me.

Thanx.
> -- Steve
>
> >   	max_data->policy = tsk->policy;
> >   	max_data->rt_priority = tsk->rt_priority;
> >   
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/