Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

From: Lee Jones
Date: Wed Mar 19 2014 - 05:14:24 EST

> Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least
> for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because
> rtc-s5m driver does not support S2MPA01.
> This fixes following error:
> drivers/mfd/sec-core.c:342:45: warning: âregmap_rtcâ may be used uninitialized in this function [-Wuninitialized]
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
> drivers/mfd/sec-core.c | 7 +++++++
> 1 file changed, 7 insertions(+)

Please don't send patches in the middle of threads like this (v2's are
a different story as it saves on re-sending entire patch-sets), as I
very nearly missed it.

We already have drivers doing similar things so I'll apply this as a
temporary fix, but please find something a little less 'hacky' to
supersede it _soon_.

Lee Jones
Linaro STMicroelectronics Landing Team Lead â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at