Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

From: Stephen Rothwell
Date: Wed Mar 19 2014 - 17:00:31 EST


On Thu, 20 Mar 2014 00:56:05 +0300 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
>
> On 03/19/2014 11:40 PM, David Miller wrote:
>
> >> +extern u8 netvsc_hash_key[];
>
> > We no longer use extern in header file function declarations.
>
> Wait, this is a variable declaration. :-)

And the need for the extern on variable declarations was one reason I
gave for not removing it from the function declarations (consistency is
good :-)).

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgpBCzhOlx99M.pgp
Description: PGP signature